NuGet packages are not deterministic

[martincostello]

Describe the bug

Viewing AWSSDK.Core 4.0.2 in NuGet Package Explorer shows various warnings about the build of the package with respect to Source Link and determinism:

The NuGet packages should be built with ContinuousIntegrationBuild=true, Deterministic=true and EmbedUntrackedSources=true to resolve this.

.NET global tools such as dotnet-validate and meziantou.framework.nugetpackagevalidation.tool can be used to verify this.

For Amazon.Lambda.Core at least, this doesn't appear to be a regression and these have never been enabled.=true` to resolve this.

.NET global tools such as dotnet-validate and meziantou.framework.nugetpackagevalidation.tool can be used to verify this.

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

Packages should be deterministic and have no untracked sources.

Current Behavior

NuGet packages are not deterministic and have untracked sources.

Reproduction Steps

View NuGet packages in NuGet Package Explorer.

Possible Solution

Set ContinuousIntegrationBuild=true, Deterministic=true and EmbedUntrackedSources=true=true MSBuild properties when building the NuGet packages for publishing to NuGet.org.

Additional Information/Context

No response

AWS .NET SDK and/or Package version used

I checked these two, but I imagine all the packages produced from this repository have the same issue:

AWSSDK.Core 4.0.2
AWSSDK.Lambda 4.0.6.1

Targeted .NET Platform

Any

Operating System and version

Any

[dscpinheiro]

Yeah, this happens for all packages in the SDK today.

This is something we should do, but never got prioritized (similar feature requests from a few years ago... #1921 and #1777).

[martincostello]

This should be pretty trivial to enable.

For example, this is what I do for my own libraries:

<PropertyGroup>
  <ContinuousIntegrationBuild>$([MSBuild]::ValueOrDefault('$(CI)', 'false'))</ContinuousIntegrationBuild>
  <Deterministic>$([MSBuild]::ValueOrDefault('$(Deterministic)', 'true'))</Deterministic>
  <EmbedUntrackedSources>$([MSBuild]::ValueOrDefault('$(EmbedUntrackedSources)', 'true'))</EmbedUntrackedSources>
</PropertyGroup>

If it was set centrally, in say Directory.Build.props, then it would fix all the assemblies in one go with minimal changes, assuming that AWS Code Build sets CI=true for your official builds.