fix(oidc): ensure unique tabIds when page is duplicated (beta) #1485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @guillaume-chervet , would you have some time to review this PR? |
Contributor
|
Very sorry for the delay @grpawel . |
Contributor
|
Hi @grpawel , very sorry for the conflict. May you resolved it and I have time tomorrow to test it well. |
grpawel
force-pushed
the
fix/duplicate-tab-2
branch
2 times, most recently
from
fd33b30 to
dff27f7
Compare
Author
|
Hi @guillaume-chervet , sorry for the delay on my side. The conflict wasn't difficult to solve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A picture tells a thousand words
This PR has the same changes as #1448, which was merged but then removed (see discussion in #1481).
See full description at #1448.
Before this PR
When user duplicates a browser tab, session storage is copied so both tabs use the same
tabId. Operations like login in one tab can override the state of another tab.After this PR
OIDC client can detect that the tab was duplicated and its
tabIdis already used.