refactor(sdk): remove ancestor completion tracking from checkpoint #379
+2
−533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ager - Remove pendingCompletions parameter from CheckpointManager constructor - Remove hasPendingAncestorCompletion and hasFinishedAncestor methods - Update all CheckpointManager instantiations across codebase - Remove ancestor checking tests that relied on removed functionality - All tests now pass (2,031 tests across 4 packages)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pendingCompletions and hasPendingAncestorCompletion does not add any value and by removing it all the tests still passes.
We added it to address issue with minSuccessful that is even with those checking does not work correctly.
This will be replaces by a better logic that works on top of Operation list (Set) available in checkpoint-manager.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.