-
Notifications
You must be signed in to change notification settings - Fork 238
Add Android 16KB page size support for Google Play compliance #1810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: sheetalarkadam <100380551+sheetalarkadam@users.noreply.github.com>
Co-authored-by: sheetalarkadam <100380551+sheetalarkadam@users.noreply.github.com>
….gradle Co-authored-by: sheetalarkadam <100380551+sheetalarkadam@users.noreply.github.com>
|
@copilot any cmake file changes needed like - https://github.com/microsoft/onnxruntime/pull/22076/files |
Co-authored-by: sheetalarkadam <100380551+sheetalarkadam@users.noreply.github.com>
Added the CMake linker flag Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Summary
This PR implements support for Android 16KB page sizes, which is required by Google Play starting November 1st, 2025 for all new apps and updates targeting Android 15+ devices.
Changes Made
1. CMake Build Configuration
-DANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ONflag to enable flexible page size supportbuild.py(main build script)examples/slm_engine/build_scripts/build.pyexamples/slm_engine/build_scripts/build_deps.py-Wl,-z,max-page-size=16384linker flag for shared libraries on AndroidCMakeLists.txtto setCMAKE_SHARED_LINKER_FLAGSfor proper 16KB ELF alignment2. Gradle Plugin Updates
src/java/build-android.gradlesrc/java/src/test/android/build.gradle3. Android SDK Version Updates
compileSdkVersionfrom 32 to 34targetSdkVersionto use thetargetSdkVervariable (set to 34 in CI settings)src/java/build-android.gradlesrc/java/src/test/android/app/build.gradletools/ci_build/github/android/default_aar_build_settings.json4. Documentation
AndroidBuild.mdCompatibility
References
Testing Notes
Manual testing recommended:
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.