expose start/end profiling API in Models class #1898
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feich-ms
reviewed
Dec 4, 2025
| } | ||
|
|
||
| void SessionInfo::Add(OrtSession& session) { | ||
| sessions_.push_back(&session); |
There was a problem hiding this comment.
Do you need to remove the session from sessions_ if the session is deleted or removed? Otherwise the pointer will be dangerous since the session it points has been removed or destroyed.
Contributor
Author
There was a problem hiding this comment.
Thanks for the callout. There is no SessionInfo::Remove(OrtSession& session). UUIC, A model own a session_info_ and multiple sessions. They are the same lifetime. That means when a session is destoryed, sessions_ is also destoryed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GenAI does not support profiling within a specific time range. This PR addresses it.
This PR introduces
start_profiling()andend_profiling()APIs in the Model class, allowing developers to perform profiling only within a selected time span.A Model owns an ONNX Runtime Session and the relationship is 1:1. Since profiling in ORT operates at the session level, we expose these APIs at the Model layer to make profiling control more accessible.
Note: We don't want to expose these in Generator layer. Because we have a concern for Generator A start profiling and Generator B end profiling.