Skip to content

Conversation

@sheetalkamat
Copy link
Member

Copilot AI review requested due to automatic review settings December 9, 2025 20:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the --builders command-line flag to limit the number of projects that can build concurrently in TypeScript project builds. The implementation introduces:

  • A new --builders option that accepts a numeric value (minimum 1)
  • Semaphore-based concurrency control in the build orchestrator
  • Validation to ensure the value is greater than or equal to 1
  • Test coverage for various scenarios including error cases
  • Updated baseline files demonstrating the feature with different project counts

Reviewed changes

Copilot reviewed 26 out of 28 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/core/buildoptions.go Adds Builders field to BuildOptions struct
internal/tsoptions/declsbuild.go Declares the --builders command-line option with validation
internal/tsoptions/declscompiler.go Adds minimum value validation to checkers option
internal/tsoptions/parsinghelpers.go Adds parsing logic for the builders option
internal/tsoptions/commandlineparser.go Implements validation for minimum value constraint on numeric options
internal/tsoptions/commandlineoption.go Adds minValue field to CommandLineOption struct
internal/execute/build/orchestrator.go Initializes semaphore for limiting concurrent builds
internal/execute/build/buildtask.go Acquires/releases semaphore slots during compilation
internal/diagnostics/extraDiagnosticMessages.json Adds diagnostic messages for the feature
internal/diagnostics/diagnostics_generated.go Generated diagnostic code
internal/execute/tsctests/tscbuild_test.go Adds test scenarios for the --builders flag
internal/tsoptions/commandlineparser_test.go Adds validation tests for edge cases
Multiple baseline files Test output baselines showing expected behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants