Genericize ref counting caches; fix extended config cache bug #2311
+270
−219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to add another one of these shared caches for parsed package.json files for the auto-imports work, so I went ahead and made the implementation generic, which required some fiddling with config file parsing to not pass a closure on every cache lookup so we don’t also pass a closure on every source file lookup. I also noticed a bug with the extended config caching, which is covered in a new test and fixed.