Allow constructing Id<T> from raw integers #187
Conversation
zxq82lm
changed the title
|
@claude /review-pr |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
carllerche
left a comment
carllerche
left a comment
There was a problem hiding this comment.
Thanks for the PR. Just FYI, I plan on completely getting rid of the ID type soon. I am OK merging a PR to make it easier to work w/ it in the mean time. Is there a reason you are converting an Int ID -> Value::String?
| pub fn to_primitive(&self) -> stmt::Value { | ||
| match &self.repr { | ||
| Repr::Int(_) => todo!(), | ||
| Repr::Int(id) => stmt::Value::String(id.to_string()), |
There was a problem hiding this comment.
Is there a reason you are converting an Int ID to a string?
There was a problem hiding this comment.
I’m doing the Int-backed Id → Value::String conversion because the current pipeline maps Type::Id to a string column (stmt_ty_to_table does Type::Id(_) => Type::String), and the drivers already serialize IDs as text. If you’d prefer a different representation I’m happy to adjust.
2 participants
PR objective
Address the issue #147.
Testing
Unit test: