Allow configuring a per-repo concurrency limit via config #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cotsog
reviewed
Apr 21, 2017
spec/travis/scheduler/limit_spec.rb
Outdated
| before { subject } | ||
|
|
||
| it { expect(subject.size).to eq 2 } | ||
| it { expect(report).to include('max jobs for repo svenfuchs/gem-release by repo_settings: 2') } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
cotsog
reviewed
Apr 21, 2017
| before { config.limit.default = 5 } | ||
| before { config.limit.by_repo = { repo.slug => 2 } } | ||
| before { create_jobs(3) } | ||
| before { repo.settings.update_attributes!(maximum_number_of_builds: 2) } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
joecorcoran
reviewed
Apr 21, 2017
Contributor
joecorcoran
left a comment
joecorcoran
left a comment
There was a problem hiding this comment.
Agree with @cotsog's changes, otherwise LGTM!
svenfuchs
force-pushed
the
sf-per-repo-config-limit
branch
from
e52fba5 to
1b9e35b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keychain:
This should set a hard limit of 1 for the repo
travis-ci/travis-ci.